Bug fix for invalid HTML in grid.inc

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug fix for invalid HTML in grid.inc

stevepiercy
I found two minor bugs in the building of the grid header HTML.  
Please see attached.

(1)  Now that the footer is an object and is a self-contained
<tr>, the preceding <tr>'s for the -quicksearch must be removed,
and a single <tr> placed after the footer object.
(2)  <tbody>...</tbody> should not wrap the footer object
because (1) it can be placed in the <thead> and (2) only one
<tbody> is allowed per table.

I tested against grid->renderhtml(-startwithfooter) and
grid->renderhtml, with quicksearch, and without quicksearch but
with a custom form, and all tests now create valid HTML.

--steve

-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
-- --
Steve Piercy               Web Site Builder              
Soquel, CA
<[hidden email]>                  <http://www.StevePiercy.com/>
--
#############################################################
This message is sent to you because you are subscribed to
the mailing list <[hidden email]>.
To unsubscribe, E-mail to: <[hidden email]>
Send administrative queries to  <[hidden email]>
List archive http://lasso.2283332.n4.nabble.com/Knop-Framework-Discussion-f3157831.html
Project homepage http://montania.se/projects/knop/
Google Code has the latest downloads at http://code.google.com/p/knop/

grid.inc (72K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Bug fix for invalid HTML in grid.inc

Johan Solve-2
Merged and commited. Thanks!


At 05.51 -0800 2011-01-01, Steve Piercy - Web Site Builder wrote:

>I found two minor bugs in the building of the grid header HTML.  Please see attached.
>
>(1)  Now that the footer is an object and is a self-contained <tr>, the preceding <tr>'s for the -quicksearch must be removed, and a single <tr> placed after the footer object.
>(2)  <tbody>...</tbody> should not wrap the footer object because (1) it can be placed in the <thead> and (2) only one <tbody> is allowed per table.
>
>I tested against grid->renderhtml(-startwithfooter) and grid->renderhtml, with quicksearch, and without quicksearch but with a custom form, and all tests now create valid HTML.
>
>--steve
>
>-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
>Steve Piercy               Web Site Builder
>Soquel, CA
><[hidden email]>                  <http://www.StevePiercy.com/>
>
>Attachment converted: MacBook Pro:grid 11.inc (TEXT/R*ch) (00C9D28A)
>--
>#############################################################
>This message is sent to you because you are subscribed to
>the mailing list <[hidden email]>.
>To unsubscribe, E-mail to: <[hidden email]>
>Send administrative queries to  <[hidden email]>
>List archive http://lasso.2283332.n4.nabble.com/Knop-Framework-Discussion-f3157831.html
>Project homepage http://montania.se/projects/knop/
>Google Code has the latest downloads at http://code.google.com/p/knop/


--
     Johan Sölve    [FSA Member, Lasso Partner]
     Web Application/Lasso/FileMaker Developer
     MONTANIA SOFTWARE & SOLUTIONS
http://www.montania.se   mailto:[hidden email]
 (spam-safe email address, replace '-' with 'a')

--
#############################################################
This message is sent to you because you are subscribed to
the mailing list <[hidden email]>.
To unsubscribe, E-mail to: <[hidden email]>
Send administrative queries to  <[hidden email]>
List archive http://lasso.2283332.n4.nabble.com/Knop-Framework-Discussion-f3157831.html
Project homepage http://montania.se/projects/knop/
Google Code has the latest downloads at http://code.google.com/p/knop/
Reply | Threaded
Open this post in threaded view
|

Re: Bug fix for invalid HTML in grid.inc

stevepiercy
Oops!  Very minor thing, I put the wrong year on my comment:

2010-01-01  SP  Correction of invalid HTML in <thead> and <tr>

Happy New Year!

--steve


On 1/2/11 at 12:19 AM, [hidden email] (Johan Solve) pronounced:

>Merged and commited. Thanks!
>
>
>At 05.51 -0800 2011-01-01, Steve Piercy - Web Site Builder wrote:
>>I found two minor bugs in the building of the grid header HTML.  Please see attached.
>>
>>(1)  Now that the footer is an object and is a self-contained <tr>, the preceding <tr>'s for the
>-quicksearch must be removed, and a single <tr> placed after the footer object.
>>(2)  <tbody>...</tbody> should not wrap the footer object because (1) it can be placed in the
><thead> and (2) only one <tbody> is allowed per table.
>>
>>I tested against grid->renderhtml(-startwithfooter) and grid->renderhtml, with quicksearch, and
>without quicksearch but with a custom form, and all tests now create valid HTML.
>>
>>--steve
>>
>>-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
>>Steve Piercy               Web Site Builder
>>Soquel, CA
>><[hidden email]>                  <http://www.StevePiercy.com/>
>>
>>Attachment converted: MacBook Pro:grid 11.inc (TEXT/R*ch) (00C9D28A)
>>--
>>#############################################################
>>This message is sent to you because you are subscribed to
>>the mailing list <[hidden email]>.
>>To unsubscribe, E-mail to: <[hidden email]>
>>Send administrative queries to  <[hidden email]>
>>List archive http://lasso.2283332.n4.nabble.com/Knop-Framework-Discussion-f3157831.html
>>Project homepage http://montania.se/projects/knop/
>>Google Code has the latest downloads at http://code.google.com/p/knop/
>
>
>--
>Johan Sölve    [FSA Member, Lasso Partner]
>Web Application/Lasso/FileMaker Developer
>MONTANIA SOFTWARE & SOLUTIONS
>http://www.montania.se   mailto:[hidden email]
>(spam-safe email address, replace '-' with 'a')
>

-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
-- --
Steve Piercy               Web Site Builder              
Soquel, CA
<[hidden email]>                  <http://www.StevePiercy.com/>


--
#############################################################
This message is sent to you because you are subscribed to
the mailing list <[hidden email]>.
To unsubscribe, E-mail to: <[hidden email]>
Send administrative queries to  <[hidden email]>
List archive http://lasso.2283332.n4.nabble.com/Knop-Framework-Discussion-f3157831.html
Project homepage http://montania.se/projects/knop/
Google Code has the latest downloads at http://code.google.com/p/knop/
Reply | Threaded
Open this post in threaded view
|

Re: Bug fix for invalid HTML in grid.inc

Johan Solve-2
Oops... It crossed my mind when I changed the version date but I still missed that one.

At 15.30 -0800 2011-01-01, Steve Piercy - Web Site Builder wrote:

>Oops!  Very minor thing, I put the wrong year on my comment:
>
>2010-01-01  SP  Correction of invalid HTML in <thead> and <tr>
>
>Happy New Year!
>
>--steve
>
>
>On 1/2/11 at 12:19 AM, [hidden email] (Johan Solve) pronounced:
>
>>Merged and commited. Thanks!
>>
>>
>>At 05.51 -0800 2011-01-01, Steve Piercy - Web Site Builder wrote:
>>>I found two minor bugs in the building of the grid header HTML.  Please see attached.
>>>
>>>(1)  Now that the footer is an object and is a self-contained <tr>, the preceding <tr>'s for the
>>-quicksearch must be removed, and a single <tr> placed after the footer object.
>>>(2)  <tbody>...</tbody> should not wrap the footer object because (1) it can be placed in the
>><thead> and (2) only one <tbody> is allowed per table.
>>>
>>>I tested against grid->renderhtml(-startwithfooter) and grid->renderhtml, with quicksearch, and
>>without quicksearch but with a custom form, and all tests now create valid HTML.
>>>
>>>--steve
>>>
>>>-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
>>>Steve Piercy               Web Site Builder
>>>Soquel, CA
>>><[hidden email]>                  <http://www.StevePiercy.com/>
>>>
>>>Attachment converted: MacBook Pro:grid 11.inc (TEXT/R*ch) (00C9D28A)
>>>--
>>>#############################################################
>>>This message is sent to you because you are subscribed to
>>>the mailing list <[hidden email]>.
>>>To unsubscribe, E-mail to: <[hidden email]>
>>>Send administrative queries to  <[hidden email]>
>>>List archive http://lasso.2283332.n4.nabble.com/Knop-Framework-Discussion-f3157831.html
>>>Project homepage http://montania.se/projects/knop/
>>>Google Code has the latest downloads at http://code.google.com/p/knop/
>>
>>
>>--
>>Johan Sölve    [FSA Member, Lasso Partner]
>>Web Application/Lasso/FileMaker Developer
>>MONTANIA SOFTWARE & SOLUTIONS
>>http://www.montania.se   mailto:[hidden email]
>>(spam-safe email address, replace '-' with 'a')
>>
>
>-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
>Steve Piercy               Web Site Builder
>Soquel, CA
><[hidden email]>                  <http://www.StevePiercy.com/>
>
>
>--
>#############################################################
>This message is sent to you because you are subscribed to
>the mailing list <[hidden email]>.
>To unsubscribe, E-mail to: <[hidden email]>
>Send administrative queries to  <[hidden email]>
>List archive http://lasso.2283332.n4.nabble.com/Knop-Framework-Discussion-f3157831.html
>Project homepage http://montania.se/projects/knop/
>Google Code has the latest downloads at http://code.google.com/p/knop/


--
     Johan Sölve    [FSA Member, Lasso Partner]
     Web Application/Lasso/FileMaker Developer
     MONTANIA SOFTWARE & SOLUTIONS
http://www.montania.se   mailto:[hidden email]
 (spam-safe email address, replace '-' with 'a')

--
#############################################################
This message is sent to you because you are subscribed to
the mailing list <[hidden email]>.
To unsubscribe, E-mail to: <[hidden email]>
Send administrative queries to  <[hidden email]>
List archive http://lasso.2283332.n4.nabble.com/Knop-Framework-Discussion-f3157831.html
Project homepage http://montania.se/projects/knop/
Google Code has the latest downloads at http://code.google.com/p/knop/